[PATCH] D130820: [cmake] Add LoongArch to config.guess

WÁNG Xuěruì via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 31 03:58:23 PDT 2022


xen0n added inline comments.


================
Comment at: llvm/cmake/config.guess:925
 	exit ;;
+    loongarch32:Linux:*:* | loongarch64:Linux:*:* | loongarchx32:Linux:*:*)
+	echo "${UNAME_MACHINE}-unknown-linux-${LIBC}"
----------------
SixWeining wrote:
> I'm not sure it exists or not. Let me double check with others internally. Thanks.
IIRC it was planned to be something like the MIPS n32, but due to the later shift to the RISC-V-like model it should no longer exist. The "LPX32" ABI should never see the light of day.

But again here I'm just updating the script to match the upstream behavior. If `loongarchx32` should be deleted here, then the upstream config.git should get updated too.


================
Comment at: llvm/cmake/config.guess:926
+    loongarch32:Linux:*:* | loongarch64:Linux:*:* | loongarchx32:Linux:*:*)
+	echo "${UNAME_MACHINE}-unknown-linux-${LIBC}"
+	exit ;;
----------------
SixWeining wrote:
> Unlike the upstream `config.git`, this file misses the initialization of `LIBC`.  Perhaps we can use `gnu` for now?
I just found out this a few minutes ago (in my test repo I just copied over the upstream script so I didn't notice). Fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130820/new/

https://reviews.llvm.org/D130820



More information about the llvm-commits mailing list