[PATCH] D130830: Don't widen shuffle element with AVX512

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:16802
+        SVOp->getMask() == Mask)
+      return SDValue();
+
----------------
Fix crashing.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:17572
+        SVOp->getMask() == Mask)
+      return SDValue();
+
----------------
Fix crashing.


================
Comment at: llvm/test/CodeGen/X86/avx512-shuffles/shuffle-blend.ll:252
 entry:
   %2 = add <8 x i32> %0, %1
   %3 = shufflevector <8 x i32> %2, <8 x i32> <i32 undef,i32 undef,i32 undef,i32 undef,i32 undef,i32 undef,i32 undef,i32 undef>, <8 x i32> <i32 0,i32 1,i32 4,i32 5,i32 2,i32 3,i32 6,i32 7>
----------------
This case cause crashing previously.


================
Comment at: llvm/test/CodeGen/X86/avx512-shuffles/shuffle-blend.ll:264
 entry:
   %2 = add <16 x i16> %0, %1
   %3 = shufflevector <16 x i16> %2, <16 x i16> <i16 undef,i16 undef,i16 undef,i16 undef,i16 undef,i16 undef,i16 undef,i16 undef,i16 undef,i16 undef,i16 undef,i16 undef,i16 undef,i16 undef,i16 undef,i16 undef>, <16 x i32> <i32 8,i32 9,i32 10,i32 11,i32 4,i32 5,i32 6,i32 7,i32 0,i32 1,i32 2,i32 3,i32 12,i32 13,i32 14,i32 15>
----------------
This case cause crashing previously.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130830/new/

https://reviews.llvm.org/D130830