[PATCH] D130452: [JITLink][COFF][x86_64] Implement remaining IMAGE_REL_AMD64_REL32_*.

[Sunho Kim via Phabricator via llvm-commits]

sunho added a comment.

In D130452#3678111 <https://reviews.llvm.org/D130452#3678111>, @lhames wrote:

> Are there test cases for this already? Can some be added?
>
> Otherwise LGTM.

It's tricky to add testcases for all relocations as llvm-mc can only generate IMAGE_REL_AMD64_REL32 and IMAGE_REL_AMD64_REL32_1 afaik. I manually created a testcase for IMAGE_REL_AMD64_REL32_4 by extracting dump from msvc genrated obj file to cover at least one representitive one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130452/new/

https://reviews.llvm.org/D130452