[llvm] ee9cf33 - [JITLink][COFF] Remove obsolete FIXMEs. (NFC)
Sunho Kim via llvm-commits
llvm-commits at lists.llvm.org
Sat Jul 30 16:10:23 PDT 2022
Author: Sunho Kim
Date: 2022-07-31T08:10:14+09:00
New Revision: ee9cf336d688fe4c308cb5723efaa05c9c826ffb
URL: https://github.com/llvm/llvm-project/commit/ee9cf336d688fe4c308cb5723efaa05c9c826ffb
DIFF: https://github.com/llvm/llvm-project/commit/ee9cf336d688fe4c308cb5723efaa05c9c826ffb.diff
LOG: [JITLink][COFF] Remove obsolete FIXMEs. (NFC)
Added:
Modified:
llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.cpp
Removed:
################################################################################
diff --git a/llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.cpp b/llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.cpp
index 76d1b4305b84..402141589034 100644
--- a/llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.cpp
+++ b/llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.cpp
@@ -141,8 +141,6 @@ Error COFFLinkGraphBuilder::graphifySections() {
<< "Creating section for \"" << SectionName << "\"\n";
});
- // FIXME: Revisit crash when dropping IMAGE_SCN_MEM_DISCARDABLE sections
-
// Get the section's memory protection flags.
MemProt Prot = MemProt::Read;
if ((*Sec)->Characteristics & COFF::IMAGE_SCN_MEM_EXECUTE)
@@ -357,7 +355,6 @@ Error COFFLinkGraphBuilder::flushWeakAliasRequests() {
}
Error COFFLinkGraphBuilder::handleAlternateNames() {
- // FIXME: Use proper alias
for (auto &KeyValue : AlternateNames)
if (DefinedSymbols.count(KeyValue.second) &&
ExternalSymbols.count(KeyValue.first)) {
More information about the llvm-commits
mailing list