[PATCH] D129643: [SCEV] Use context to strengthen flags of BinOps

Daniil Suchkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 30 15:23:36 PDT 2022


DaniilSuchkov added a comment.

The change seems reasonable.

One potentially concerning thing is if we start using context for inferring no-wrap flags, we theoretically can complete the "there's a check => doesn't overflow, doesn't overflow => doesn't need the check" circle. But even if we do, it seems, the problem would be on the side of the transformation, removing checks based on flags.

Please wait few more days and then feel free to land if no one objects.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129643/new/

https://reviews.llvm.org/D129643



More information about the llvm-commits mailing list