[PATCH] D130814: [Orc] Disable use of shared memory on Android

Sat Jul 30 13:29:19 PDT 2022

sgraenitz added a reviewer: sgraenitz.
sgraenitz added a comment.

Not sure about Lang's availability right now. I can sign this off as well if necessary.

================
Comment at: llvm/lib/ExecutionEngine/Orc/MemoryMapper.cpp:192
+  return make_error<StringError>(
+      "SharedMemoryMapper is not supported on this platform yet");
+#endif
----------------
You have to pass a `std::error_code` here as well. Either try and find a matching standard error code or use `llvm::inconvertibleErrorCode()`.

================
Comment at: llvm/lib/ExecutionEngine/Orc/TargetProcess/ExecutorSharedMemoryMapperService.cpp:63
     SharedMemoryNameStream << "/jitlink_" << sys::Process::getProcessId() << '_'
                            << (++SharedMemoryCount);
     SharedMemoryName = SharedMemoryNameStream.str();
----------------
As mentioned in the mail: `SharedMemoryCount` should be `#ifdef`ed in the header. Otherwise it's a unused private field and triggers a warning / error (with `-Werror`).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130814/new/

https://reviews.llvm.org/D130814