[PATCH] D130718: [compiler-rt] [builtins] Detect _Float16 support at compile time

[Phoebe Wang via Phabricator via llvm-commits]

pengfei reopened this revision.
pengfei added a comment.
This revision is now accepted and ready to land.

In D130718#3688602 <https://reviews.llvm.org/D130718#3688602>, @fmayer wrote:

> I think this broke the sanitizer-windows buildbot: https://lab.llvm.org/buildbot/#/builders/127/builds/33583/steps/4/logs/stdio
>
>   [99/120] Running the Builtins tests
>   -- Testing: 214 tests, 16 workers --
>   Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60..
>   FAIL: Builtins-x86_64-windows :: truncdfhf2_test.c (53 of 214)
>   ******************** TEST 'Builtins-x86_64-windows :: truncdfhf2_test.c' FAILED ********************
>   Script:
>   --
>   : 'RUN: at line 1';       C:/b/slave/sanitizer-windows/build/stage1/./bin/clang.exe   -gline-tables-only -gcodeview -gcolumn-info     -fno-builtin -I C:/b/slave/sanitizer-windows/llvm-project/compiler-rt\lib\builtins -nodefaultlibs C:\b\slave\sanitizer-windows\llvm-project\compiler-rt\test\builtins\Unit\truncdfhf2_test.c C:/b/slave/sanitizer-windows/build/stage1/./lib/clang/16.0.0/lib/windows\clang_rt.builtins-x86_64.lib -o C:\b\slave\sanitizer-windows\build\stage1\projects\compiler-rt\test\builtins\Unit\X86_64WindowsConfig\Output\truncdfhf2_test.c.tmp &&  C:\b\slave\sanitizer-windows\build\stage1\projects\compiler-rt\test\builtins\Unit\X86_64WindowsConfig\Output\truncdfhf2_test.c.tmp
>   --
>   Exit Code: 1
>   Command Output (stdout):
>   --
>   $ ":" "RUN: at line 1"
>   $ "C:/b/slave/sanitizer-windows/build/stage1/./bin/clang.exe" "-gline-tables-only" "-gcodeview" "-gcolumn-info" "-fno-builtin" "-I" "C:/b/slave/sanitizer-windows/llvm-project/compiler-rt\lib\builtins" "-nodefaultlibs" "C:\b\slave\sanitizer-windows\llvm-project\compiler-rt\test\builtins\Unit\truncdfhf2_test.c" "C:/b/slave/sanitizer-windows/build/stage1/./lib/clang/16.0.0/lib/windows\clang_rt.builtins-x86_64.lib" "-o" "C:\b\slave\sanitizer-windows\build\stage1\projects\compiler-rt\test\builtins\Unit\X86_64WindowsConfig\Output\truncdfhf2_test.c.tmp"
>   $ "C:\b\slave\sanitizer-windows\build\stage1\projects\compiler-rt\test\builtins\Unit\X86_64WindowsConfig\Output\truncdfhf2_test.c.tmp"
>   # command output:
>   error in test__truncdfhf2(nan) = 0000, expected 0x7e00
>   error: command failed with exit status: 1
>   --
>   ********************
>   Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.
>   FAIL: Builtins-x86_64-windows :: truncsfhf2_test.c (212 of 214)
>   ******************** TEST 'Builtins-x86_64-windows :: truncsfhf2_test.c' FAILED ********************
>   Script:
>   --
>   : 'RUN: at line 1';       C:/b/slave/sanitizer-windows/build/stage1/./bin/clang.exe   -gline-tables-only -gcodeview -gcolumn-info     -fno-builtin -I C:/b/slave/sanitizer-windows/llvm-project/compiler-rt\lib\builtins -nodefaultlibs C:\b\slave\sanitizer-windows\llvm-project\compiler-rt\test\builtins\Unit\truncsfhf2_test.c C:/b/slave/sanitizer-windows/build/stage1/./lib/clang/16.0.0/lib/windows\clang_rt.builtins-x86_64.lib -o C:\b\slave\sanitizer-windows\build\stage1\projects\compiler-rt\test\builtins\Unit\X86_64WindowsConfig\Output\truncsfhf2_test.c.tmp &&  C:\b\slave\sanitizer-windows\build\stage1\projects\compiler-rt\test\builtins\Unit\X86_64WindowsConfig\Output\truncsfhf2_test.c.tmp
>   --
>   Exit Code: 1
>   Command Output (stdout):
>   --
>   $ ":" "RUN: at line 1"
>   $ "C:/b/slave/sanitizer-windows/build/stage1/./bin/clang.exe" "-gline-tables-only" "-gcodeview" "-gcolumn-info" "-fno-builtin" "-I" "C:/b/slave/sanitizer-windows/llvm-project/compiler-rt\lib\builtins" "-nodefaultlibs" "C:\b\slave\sanitizer-windows\llvm-project\compiler-rt\test\builtins\Unit\truncsfhf2_test.c" "C:/b/slave/sanitizer-windows/build/stage1/./lib/clang/16.0.0/lib/windows\clang_rt.builtins-x86_64.lib" "-o" "C:\b\slave\sanitizer-windows\build\stage1\projects\compiler-rt\test\builtins\Unit\X86_64WindowsConfig\Output\truncsfhf2_test.c.tmp"
>   $ "C:\b\slave\sanitizer-windows\build\stage1\projects\compiler-rt\test\builtins\Unit\X86_64WindowsConfig\Output\truncsfhf2_test.c.tmp"
>   # command output:
>   error in test__truncsfhf2(nan) = 0000, expected 0x7e00
>   error: command failed with exit status: 1
>   --

Thanks for the reporting. Reverted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130718/new/

https://reviews.llvm.org/D130718