[PATCH] D130745: [llvm-cov][WIP] Add Per Directory coverage to llvm-cov

Fri Jul 29 14:55:11 PDT 2022

phosek added a comment.

For future revisions, please use larger context as described in https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

================
Comment at: llvm/tools/llvm-cov/SourceCoverageViewHTML.cpp:71
 const char *BeginHeader =
-  "<head>"
+    "<head>"
     "<meta name='viewport' content='width=device-width,initial-scale=1'>"
----------------
This looks like an unrelated change.

================
Comment at: llvm/tools/llvm-cov/SourceCoverageViewHTML.cpp:357
+    while (!DirPath.equals("/")) {
+      std::cout << "DEBUG: " << DirPath.str() << "\n";
+      ParentDir = Dirs.try_emplace(DirPath,
----------------
For debugging output, we usually use the `LLVM_DEBUG` macro and the `dbgs()` stream, see https://llvm.org/docs/ProgrammersManual.html#the-llvm-debug-macro-and-debug-option

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130745/new/

https://reviews.llvm.org/D130745