[PATCH] D130049: [WinEH][ARM64] Split unwind info for functions larger than 1MB

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.

LGTM, thanks! Nothing more from me here, if @efriedma is ok with it. A couple very minor stylistic comments remain.



================
Comment at: llvm/lib/MC/MCWin64EH.cpp:1034
+      if (E < Epilogs.size() && Epilogs[E].Offset <= SegEnd)
+      // Move back current Segment's end boundry.
+        SegLength = Epilogs[E].Offset - SegOffset;
----------------
Nitpick: the indentation of the comment, between the unscoped `if()` and the statement it controls, is a bit weird. I'd prefer to move the comment to the end of the `SegLength = ..` line to keep it clearer, or add braces around it (and fix the indentation of the comment).


================
Comment at: llvm/lib/MC/MCWin64EH.cpp:1145
+      report_fatal_error(
+          "SEH unwind data splitting is only implemnted for large functions,"
+          "cases of too many code words or too many epilogs will be done later"
----------------
Super-nitpick: You're missing a space after the comma, before the following text in the next string literal on the next line.


================
Comment at: llvm/test/MC/AArch64/seh-large-func.s:23
+// CHECK-NEXT:   }
+// CHECK-NEXT:  Section {
+// CHECK-NEXT:     Number: 5
----------------
Super nitpick: You seem to have lost a space before `Section {` here, making it misaligned.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130049/new/

https://reviews.llvm.org/D130049