[PATCH] D130677: [AMDGPU] Fix DGEMM hazard for GFX90a

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 29 13:43:41 PDT 2022


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp:2346
+          auto IsDGEMMHazard = [this](const MachineInstr &MI) {
+            if (!TII.isVALU(MI))
+              return false;
----------------
In fact you are using getWaitStatesSinceDef, so all you you need to check there is a DGEMM on path. Instead of the whole this function you could just `return isDGEMM(MI.getOpcode())`. No even need in a custom IsExpired or capturing anything.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130677/new/

https://reviews.llvm.org/D130677



More information about the llvm-commits mailing list