[PATCH] D129122: ManagedStatic: remove from PassManagerBuilder
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 29 13:29:00 PDT 2022
efriedma added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/PassManagerBuilder.cpp:239
// has already been destroyed; doing so should not generate an error.
- if (!GlobalExtensions.isConstructed())
+ if (!GlobalExtensionsConstructed)
return;
----------------
I don't think you've managed to quite capture the intended semantic here. Note the comment mentions what happens after GlobalExtensions is destroyed...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129122/new/
https://reviews.llvm.org/D129122
More information about the llvm-commits
mailing list