[PATCH] D130738: [lld][WebAsssembly] Convert more tests from IR to assembly. NFC

Fri Jul 29 11:39:53 PDT 2022

sbc100 added a comment.

In D130738#3688001 <https://reviews.llvm.org/D130738#3688001>, @dschuff wrote:

> LGTM.
> As we move more of ld tests to .s I assume (hope?) we have corresponding tests that cover the IR part of the translation, e.g. testing that `extern weak global` in IR results in `.weak` in the assembly...

Yes, there should be nothing in the IR that gets tested here under `lld`.   That would be really odd/wrong.

In the case of `.weak` we have `llvm/test/CodeGen/WebAssembly/weak.ll`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130738/new/

https://reviews.llvm.org/D130738