[compiler-rt] cea1b79 - [TSan][Darwin] Additional TSAN test requiring weak symbol for dyld64

Blue Gaston via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 29 11:24:49 PDT 2022


Author: Blue Gaston
Date: 2022-07-29T11:24:40-07:00
New Revision: cea1b790f6efa9ac225454aad98a576a4916d376

URL: https://github.com/llvm/llvm-project/commit/cea1b790f6efa9ac225454aad98a576a4916d376
DIFF: https://github.com/llvm/llvm-project/commit/cea1b790f6efa9ac225454aad98a576a4916d376.diff

LOG: [TSan][Darwin] Additional TSAN test requiring weak symbol for dyld64

Tests require a weak symbol for dyld weak-def coalescing.

Differential Revision: https://reviews.llvm.org/D130732

Adding additional weak attribute

Added: 
    

Modified: 
    compiler-rt/test/tsan/cxa_guard_acquire.cpp
    compiler-rt/test/tsan/default_options.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/test/tsan/cxa_guard_acquire.cpp b/compiler-rt/test/tsan/cxa_guard_acquire.cpp
index cdbe609003d43..d483cd37f328f 100644
--- a/compiler-rt/test/tsan/cxa_guard_acquire.cpp
+++ b/compiler-rt/test/tsan/cxa_guard_acquire.cpp
@@ -4,10 +4,16 @@
 
 namespace __tsan {
 
+#if (__APPLE__)
+__attribute__((weak))
+#endif
 void OnPotentiallyBlockingRegionBegin() {
   printf("Enter __cxa_guard_acquire\n");
 }
 
+#if (__APPLE__)
+__attribute__((weak))
+#endif
 void OnPotentiallyBlockingRegionEnd() { printf("Exit __cxa_guard_acquire\n"); }
 
 } // namespace __tsan

diff  --git a/compiler-rt/test/tsan/default_options.cpp b/compiler-rt/test/tsan/default_options.cpp
index 77bdcd5086baa..3b447e734f23f 100644
--- a/compiler-rt/test/tsan/default_options.cpp
+++ b/compiler-rt/test/tsan/default_options.cpp
@@ -2,6 +2,9 @@
 #include <pthread.h>
 #include <stdio.h>
 
+#if (__APPLE__)
+__attribute__((weak))
+#endif
 extern "C" const char *__tsan_default_options() {
   return "report_bugs=0";
 }


        


More information about the llvm-commits mailing list