[PATCH] D123693: Transform illegal intrinsics to V_ILLEGAL

[Brendon Cahoon via Phabricator via llvm-commits]

bcahoon added a comment.

A couple more tests are needed. A test for for the image intrinsic. Also an assembler test for the v_illegal encoding.



================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:7827
+        return makeV_ILLEGAL(Op, DAG);
+      }
+      LLVM_FALLTHROUGH;
----------------
no braces needed


================
Comment at: llvm/lib/Target/AMDGPU/SIInstructions.td:3368
+  let Uses = [EXEC];
+}
----------------
Do we need different version for gfx10?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123693/new/

https://reviews.llvm.org/D123693