[PATCH] D130782: [DAGCombiner] Extend visitAND to include EXTRACT_SUBVECTOR

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm accepted this revision.
paulwalker-arm added a comment.
This revision is now accepted and ready to land.

A couple of naming issues but otherwise looks good.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:6361-6362
+      ISD::isExtOpcode(N0.getOperand(0).getOpcode())) {
+    SDValue AnyExt = N0.getOperand(0);
+    EVT AnyExtVT = AnyExt->getValueType(0);
+    SDValue Extendee = AnyExt->getOperand(0);
----------------
With the enhanced combine the original variable names are not strictly correct.


================
Comment at: llvm/test/CodeGen/AArch64/extract-subvec-combine.ll:22
+; CHECK-NEXT:    ret
+  %zext = sext <8 x i8> %vec to <8 x i16>
+  %extract = call <4 x i16> @llvm.vector.extract.v4i16.v8i16(<8 x i16> %zext, i64 0)
----------------
sext?


================
Comment at: llvm/test/CodeGen/AArch64/extract-subvec-combine.ll:48
+; CHECK-NEXT:    ret
+  %zext = sext <8 x i8> %vec to <8 x i16>
+  %extract = call <4 x i16> @llvm.vector.extract.v4i16.v8i16(<8 x i16> %zext, i64 4)
----------------
sext?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130782/new/

https://reviews.llvm.org/D130782