[PATCH] D130752: [IRBuilder] Make createCallHelper a member function. NFC.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 29 08:32:05 PDT 2022


nikic added inline comments.


================
Comment at: llvm/lib/IR/IRBuilder.cpp:148
 
-  CallInst *CI = createCallHelper(TheFn, Ops, this);
+  CallInst *CI = createCallHelper(TheFn, Ops);
 
----------------
As far as I can tell, most of these should just use CreateCall, rather than createCallHelper. The only thing createCallHelper adds is copying FMF, and most of these usages don't specify an FMFSource.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130752/new/

https://reviews.llvm.org/D130752



More information about the llvm-commits mailing list