[PATCH] D128070: [Support] Change TrackingStatistic and NoopStatistic to use uint64_t instead of unsigned

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D128070#3593045 <https://reviews.llvm.org/D128070#3593045>, @MaskRay wrote:

> We check 64-bit atomic support (CMake `check_working_cxx_atomics64`), so the new use is fine. It may be first time LLVMSupport uses it, though (not checked very carefully).

Not just LLVMSupport, from what I can tell this is the first time LLVM requires libatomic -- previously this was only needed to work around compiler bugs (e.g. GCC targeting RISCV incorrectly used libatomic in some cases). That libatomic is now required for all 32-bit targets is quite unfortunate.

Is there some way that a consumer statically linking LLVM can detect which libraries they need to link when cross-compiling? llvm-config has this information, but obviously it doesn't work when cross-compiling. The cmake exports don't seem to have the information (and having to parse cmake files to extract this would certainly be not great).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128070/new/

https://reviews.llvm.org/D128070