[PATCH] D130742: [AMDGPU] Extend SILoadStoreOptimizer to s_load instructions

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 29 07:19:08 PDT 2022


foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

LGTM, thanks! The SILoadStoreOptimizer.cpp diff is impressively small.

In future perhaps we should also handle the *_SGPR_IMM forms of various SMEM loads.



================
Comment at: llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:2336
+    case S_LOAD_IMM:
       NewMI = mergeSBufferLoadImmPair(CI, Paired, Where->I);
       OptimizeListAgain |= CI.Width + Paired.Width < 8;
----------------
Maybe rename to something like `mergeSMEMLoadImmPair`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130742/new/

https://reviews.llvm.org/D130742



More information about the llvm-commits mailing list