[PATCH] D130774: [NFC] Remove redundant CalculateSmallVectorDefaultInlinedElements usage from to_vector utility

Dawid Jurczak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 29 06:42:07 PDT 2022


yurai007 created this revision.
yurai007 added reviewers: dblaikie, nikic, dexonsmith, wolfgangp, jhenderson.
Herald added a project: All.
yurai007 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

CalculateSmallVectorDefaultInlinedElements<..>::value is already used as default value for second template parameter in SmallVector class declaration. 
There is no need to pass it explicitly in to_vector.

Extracted from: https://reviews.llvm.org/D129781


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D130774

Files:
  llvm/include/llvm/ADT/SmallVector.h


Index: llvm/include/llvm/ADT/SmallVector.h
===================================================================
--- llvm/include/llvm/ADT/SmallVector.h
+++ llvm/include/llvm/ADT/SmallVector.h
@@ -1282,10 +1282,7 @@
   return {std::begin(Range), std::end(Range)};
 }
 template <typename R>
-SmallVector<ValueTypeFromRangeType<R>,
-            CalculateSmallVectorDefaultInlinedElements<
-                ValueTypeFromRangeType<R>>::value>
-to_vector(R &&Range) {
+SmallVector<ValueTypeFromRangeType<R>> to_vector(R &&Range) {
   return {std::begin(Range), std::end(Range)};
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130774.448613.patch
Type: text/x-patch
Size: 577 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220729/f281333f/attachment.bin>


More information about the llvm-commits mailing list