[PATCH] D130761: [AMDGPU][MC] Verify selection of LDS MUBUF opcodes

[Dmitry Preobrazhensky via Phabricator via llvm-commits]

dp added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:4495-4498
+  if (Enc == SIInstrFlags::FLAT && isGFX940())
+    return true;
+  if (Enc == SIInstrFlags::MUBUF && isGFX11Plus())
     return true;
----------------
foad wrote:
> What do these lines achieve?
These lines exclude checks for cases when there are separate DMA opcodes. In these cases, incorrect opcode selection is not possible.

GFX940 FLAT opcodes do not support `lds` modifier, but there are separate DMA opcodes `global_load_lds_dword`, etc.

Likewise, GFX11 has `buffer_load_lds_b32`, etc; MUBUF `lds` modifier is not supported.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130761/new/

https://reviews.llvm.org/D130761