[PATCH] D130445: [DAG] Use recursivelyDeleteUnusedNodes in CommitTargetLoweringOpt.

[Amaury SECHET via Phabricator via llvm-commits]

deadalnix added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:1209
-  // are deleted, make sure to remove them from our worklist.
-  WorklistRemover DeadNodes(*this);
   DAG.ReplaceAllUsesOfValueWith(TLO.Old, TLO.New);
----------------
craig.topper wrote:
> Why don't we need the WorklistRemove here anymore? The comment applies to what can happen inside of ReplaceAllUsesOfValueWith.
The run call itself already adds a WorkListRemover, so this one is redundant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130445/new/

https://reviews.llvm.org/D130445