[PATCH] D128180: [DebugInfo][InstrRef][NFC] Let LDV handle joins for lists of debug ops

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer updated this revision to Diff 448574.
StephenTozer added a comment.

Added some unit tests - I've only added a few, since there's little to test w.r.t. variadic stuff specifically: primarily just that we can join operands for variadic debug values, and that if the join is invalid for at least one operand then the whole thing is invalid; otherwise the function is pretty much just calling the old logic on each element of a list.

Addressed the review comments, with the exception of the `const DbgOp &` suggestion, because I think it would be better to just make DbgOp smaller (which I'll add separate to this patch).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128180/new/

https://reviews.llvm.org/D128180

Files:
  llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp
  llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h
  llvm/unittests/CodeGen/InstrRefLDVTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D128180.448574.patch
Type: text/x-patch
Size: 25271 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220729/c75ccfca/attachment.bin>