[PATCH] D96035: [dsymutil][DWARFlinker] implement separate multi-thread processing for compile units.

[Alexey Lapshin via Phabricator via llvm-commits]

avl added a comment.

In D96035#3685513 <https://reviews.llvm.org/D96035#3685513>, @clayborg wrote:

> In D96035#3685472 <https://reviews.llvm.org/D96035#3685472>, @avl wrote:
>
>> In D96035#3684041 <https://reviews.llvm.org/D96035#3684041>, @dreampiggy wrote:
>>
>>>> DW_TAG_thrown_type is currently not handled by new DWARFLinker(as well as by old DWARFLinker)
>>>
>>> Yes. But seems the old DWARFLinker DIECloner does not hit any assert and crash. Seems the new "artificial compile unit" based on types name will fail on this case ?
>>
>> yes, it will fail. Thus, it is necessary to add(other than adding specific handling for DW_TAG_thrown_type) default handler for unknown DW_TAG_* die. So that the patch do not crash in such a case. Will do this with nearest rebasing.
>
> It should be as easy as classifying DW_TAG_thrown_type as a type die right?

Yes, we can classify DW_TAG_thrown_type as a deduplication candidate and this concrete case should be cured.

Additionally we can extend the rule for deduplication candidates in such way: All children of the known deduplication candidate should also be considered as a deduplication candidates - that allows to not create a fixed list.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96035/new/

https://reviews.llvm.org/D96035