[PATCH] D130036: [BOLT] Remove --allow-stripped option
Amir Ayupov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 28 23:16:08 PDT 2022
This revision was automatically updated to reflect the committed changes.
Closed by commit rGccabbfff86a0: [BOLT] Remove --allow-stripped option (authored by nhuhuan, committed by Amir).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130036/new/
https://reviews.llvm.org/D130036
Files:
bolt/lib/Rewrite/RewriteInstance.cpp
Index: bolt/lib/Rewrite/RewriteInstance.cpp
===================================================================
--- bolt/lib/Rewrite/RewriteInstance.cpp
+++ bolt/lib/Rewrite/RewriteInstance.cpp
@@ -92,12 +92,6 @@
"output binary via bolt info section"),
cl::cat(BoltCategory));
-cl::opt<bool>
-AllowStripped("allow-stripped",
- cl::desc("allow processing of stripped binaries"),
- cl::Hidden,
- cl::cat(BoltCategory));
-
cl::opt<bool> DumpDotAll(
"dump-dot-all",
cl::desc("dump function CFGs to graphviz format after each stage;"
@@ -2813,13 +2807,11 @@
if (Error E = ProfileReader->preprocessProfile(*BC.get()))
report_error("cannot pre-process profile", std::move(E));
- if (!BC->hasSymbolsWithFileName() && ProfileReader->hasLocalsWithFileName() &&
- !opts::AllowStripped) {
+ if (!BC->hasSymbolsWithFileName() && ProfileReader->hasLocalsWithFileName()) {
errs() << "BOLT-ERROR: input binary does not have local file symbols "
"but profile data includes function names with embedded file "
"names. It appears that the input binary was stripped while a "
- "profiled binary was not. If you know what you are doing and "
- "wish to proceed, use -allow-stripped option.\n";
+ "profiled binary was not\n";
exit(1);
}
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130036.448521.patch
Type: text/x-patch
Size: 1366 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220729/c1b09441/attachment.bin>
More information about the llvm-commits
mailing list