[PATCH] D129952: [ORC][COFF] Handle COFF import files of static archive.

[Sunho Kim via Phabricator via llvm-commits]

sunho marked 4 inline comments as done.
sunho added inline comments.


================
Comment at: llvm/tools/llvm-jitlink/llvm-jitlink.cpp:1595
+  };
+  llvm::PriorityQueue<LibraryLoad, SmallVector<LibraryLoad, 2>, decltype(Comp)>
+      LibraryLoadQueue(Comp);
----------------
lhames wrote:
> What's the rationale behind the switch to a priority queue? Unless there's a good reason for the switch this should stay as a `std::vector`, just to minimize the differences introduced in this patch.
We still need another type of data structure to "push_front" We could reverse the order of sorting -- but that makes it more confusing in my opinion. I changed it to deque to keep it similar in terms of code and performance while enabling to push load job in the middle.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129952/new/

https://reviews.llvm.org/D129952