[PATCH] D130370: [llvm] Always use TargetConstant for FP_ROUND ISD Nodes

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added a comment.

This looks like a sensible first step to me[1]. That said, looking at the definition of `getIntPtrConstant` shows it has an `isTarget` operand so perhaps you can simplify the patch by just updating the existing `getIntPtrConstant` calls to set this parameter?

[1] Part of me wondered why this data is an operand at all, rather than being an SDFlag.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130370/new/

https://reviews.llvm.org/D130370