[PATCH] D130433: [InstCombine] Add fold for redundant sign bits count comparison

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/icmp.ll:4164
 
 define i1 @redundant_sign_bit_count_ult_31_30_extra_use_ashr(i32 %x) {
 ; CHECK-LABEL: @redundant_sign_bit_count_ult_31_30_extra_use_ashr(
----------------
Unless you found a regression from this, I think we should allow the transform here. 

It's the same number of instructions, but it removes a use of %y, so that could enable other transforms, and it would be generally better for codegen (more throughput).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130433/new/

https://reviews.llvm.org/D130433