[PATCH] D130429: [lld-macho] `-exported_symbols` should hide symbols before LTO runs
    Jez Ng via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Jul 28 14:52:46 PDT 2022
    
    
  
int3 marked an inline comment as done.
int3 added inline comments.
================
Comment at: lld/MachO/Driver.cpp:537
     inputFiles.insert(file);
+    didCompile = true;
+  }
----------------
thevinster wrote:
> Instead of needing to set `didCompile` on every loop iteration, we could extract `lto->compile` into another variable and set `didCompile` based on the size of that variable? It's minor but feels cleaner this way. 
good idea :)
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130429/new/
https://reviews.llvm.org/D130429
    
    
More information about the llvm-commits
mailing list