[PATCH] D107655: Correctly decode `UOP_Epilog` opcodes in `llvm-objdump`

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 28 14:37:00 PDT 2022


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

We have some test gap but that may be fine, as there are a few other unwind opcodes which are untested.
Still be good to add the coverage. You can run `obj2yaml llvm/test/tools/llvm-objdump/COFF/Inputs/win64-unwind.exe.coff-x86_64.exe` to get a YAML, clean it a bit, and create a `# RUN: yaml2obj %s -o %t` test.



================
Comment at: llvm/tools/llvm-objdump/COFFDump.cpp:44
   case UOP_SaveNonVolBig: return "UOP_SaveNonVolBig";
+  case UOP_Epilog:return "UOP_Epilog";
+  case UOP_SpareCode: return "UOP_SpareCode";
----------------
Add a space after `:`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107655/new/

https://reviews.llvm.org/D107655



More information about the llvm-commits mailing list