[PATCH] D119412: github: Automatically create backport requests for bugs referenced in commit messages

[Konrad Wilhelm Kleine via Phabricator via llvm-commits]

kwk added inline comments.


================
Comment at: .github/workflows/issue-release-workflow.yml:40
+      - name: Fetch LLVM sources
+        uses: actions/checkout at v2
+        with:
----------------
Just as a hint: I noticed in one of your other PRs that they have released v3 and you're using it there.


================
Comment at: llvm/utils/git/github-automation.py:33-42
+    request = requests.post(
+        url = 'https://api.github.com/graphql',
+        json = {"query" : query, "variables" : variables },
+        headers = headers)
+
+    if request.status_code == 200:
+        return request.json()['data']
----------------
I wonder if this shouldn't be renamed from `request` to `response`.


================
Comment at: llvm/utils/git/github-automation.py:429
+        """
+        Request a cherry-pick of the commits that fixed `issue` by creating a new
+        issue and attaching it to the release milestone.
----------------



================
Comment at: llvm/utils/git/github-automation.py:488
 release_workflow_parser = subparsers.add_parser('release-workflow')
 release_workflow_parser.add_argument('--llvm-project-dir', type=str, default='.', help='directory containing the llvm-project checout')
 release_workflow_parser.add_argument('--issue-number', type=int, required=True, help='The issue number to update')
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119412/new/

https://reviews.llvm.org/D119412