[PATCH] D130725: [lld/mac] Add support for $ld$previous symbols with explicit symbol name

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: lld/MachO/InputFiles.h:238
   unsigned numReferencedSymbols = 0;
-  RefState refState;
+  RefState refState = RefState::Unreferenced;
   bool reexport = false;
----------------
Moving this to an initializer is mostly unrelated, just didn't want to duplicate it in the 3rd ctor. I could land this change as a tiny standalone commit if you want.


================
Comment at: lld/MachO/Writer.cpp:797
 
-        dylibFile->reexport = false;
-        continue;
-      }
+  for (DylibFile *dylibFile : dylibFiles) {
+    if (dylibFile->isBundleLoader) {
----------------
The

```
std::vector<DylibFile *> dylibFiles;
  for (InputFile *file : inputFiles) {
    if (auto *dylibFile = dyn_cast<DylibFile>(file))
      dylibFiles.push_back(dylibFile);
  }
```

bit and dedenting this for loop here could also land in its own commit, to make this diff smaller, if you want.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130725/new/

https://reviews.llvm.org/D130725