[PATCH] D130683: [lld-macho] Allow linking with ABI compatible architectures

[Jez Ng via Phabricator via llvm-commits]

int3 accepted this revision.
int3 added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: lld/MachO/InputFiles.cpp:1877-1881
+  auto it = llvm::find_if(archSet, [&](const auto &p) {
+    std::tie(cpuType, std::ignore) = getCPUTypeFromArchitecture(p);
+    return cpuType == targetCpuType;
+  });
+  return it != archSet.end();
----------------



================
Comment at: lld/MachO/InputFiles.cpp:1896-1897
+
+  if (config->forceExactCpuSubtypeMatch)
+    return false;
+
----------------
we can move this to line 1888 I think? doesn't seem like computing `archSet` is necessary if `forceExactCpuSubtypeMatch == true`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130683/new/

https://reviews.llvm.org/D130683