[PATCH] D128941: [ModuloSchedule] Add interface call to accept/reject SMS schedules

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

OK. The logic looks OK to me, and we can always move the code if another target finds a use for it.
LGTM with a few suggestions



================
Comment at: llvm/include/llvm/CodeGen/TargetInstrInfo.h:738
 
+    /// Return true if the proposed schedule should used.  Otherwise return
+    /// false. This function can be used to ensure that pipelined loops meet
----------------
dmgreen wrote:
> "should be used"
> Perhaps explain that returning false means no pipelined loops too. "Otherwise return false to not pipeline the loop."
"should used" > "should be used"


================
Comment at: llvm/lib/CodeGen/MachinePipeliner.cpp:2097
 
+
   LLVM_DEBUG(dbgs() << "Schedule Found? " << scheduleFound
----------------
Remove this extra line.


================
Comment at: llvm/lib/Target/Hexagon/HexagonInstrInfo.cpp:753
 
+  bool shouldUseSchedule(SwingSchedulerDAG &SSD, SMSchedule &SMS) override {
+    return true;
----------------
You could perhaps just make the default PipelinerLoopInfo::shouldUseSchedule return true to avoid these overrides.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128941/new/

https://reviews.llvm.org/D128941