[PATCH] D130564: [AArch64][SVE] Add patterns to select masked FP arith

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td:373-374
+    return true;  // it's the intrinsic
+  SDValue Sel = N->getOperand(2);
+  SDValue FMul = Sel->getOperand(1);
+  return N->getFlags().hasAllowContract() &&
----------------
Do flags on the fmul matter?  It's the result of the fadd/fsub that's affected by the contraction and so I think only those nodes require the contract flag.

I'm not totally sure but I do wonder if we need to also check for no-signed-zeros because for the equivalent reduction code -0.0 is the nop value.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130564/new/

https://reviews.llvm.org/D130564