[PATCH] D119412: github: Automatically create backport requests for bugs referenced in commit messages

[Tom Stellard via Phabricator via llvm-commits]

tstellar added inline comments.


================
Comment at: .github/workflows/issue-release-workflow.yml:58
         (github.repository == 'llvm/llvm-project') &&
+        github.event.action != 'closed' &&
         !startswith(github.event.comment.body, '<!--IGNORE-->') &&
----------------
kwk wrote:
> While this may be okay for now I suggest to make this selection explicit instead of indirectly implicit. The next time you add or remove an event type in the `on` section above (e.g. add `labeled` as an event type), the logic here breaks. I suggest to have this formulated out. Here's a list of all possible activity types: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#issues . You certainly limit the scope in the `on` section already but the moment you widen this, you have to check this place again. And that should be avoided IMHO.
Would it be better just to move this new job to another file?  That would avoid having all the complicated logic to filter out the different event types.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119412/new/

https://reviews.llvm.org/D119412