[PATCH] D130675: [RFC][DAG] Match select of constant equivalents in foldBinOpIntoSelect.

[Amaury SECHET via Phabricator via llvm-commits]

deadalnix added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:2256
+
+    if (V.getOpcode() == ISD::XOR && isOneConstant(V.getOperand(1))) {
+      V = V.getOperand(0);
----------------
spatel wrote:
> Does this need to use TLI.getBooleanContents() for non i1 types?
Is here a predicate to check if something is a "not"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130675/new/

https://reviews.llvm.org/D130675