[PATCH] D130675: [RFC][DAG] Match select of constant equivalents in foldBinOpIntoSelect.

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

I don't have a problem with the direction, but as noted earlier, all of the x86 tests that changed to cmov would likely be viewed as regressions. Maybe we can predicate with the phase of combining to limit those diffs?



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:2256
+
+    if (V.getOpcode() == ISD::XOR && isOneConstant(V.getOperand(1))) {
+      V = V.getOperand(0);
----------------
Does this need to use TLI.getBooleanContents() for non i1 types?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130675/new/

https://reviews.llvm.org/D130675