[PATCH] D130427: RegAllocGreedy: Avoid overflowing priority bitfields

[Jay Foad via Phabricator via llvm-commits]

foad added a subscriber: hfinkel.
foad added a comment.

LGTM with the comment fixed, but it would be nice to get an ack from the PPC maintainers (or maybe @hfinkel).



================
Comment at: llvm/lib/CodeGen/RegAllocGreedy.cpp:332-333
+    // 30 Preference priority
+    // 29 Global bit
+    // 28-24 AllocPriority
+    // 0-23 Size/Instr distance
----------------
foad wrote:
> These two get swapped by RegClassPriorityTrumpsGlobalness.
You've got the if/else cases the wrong way round.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130427/new/

https://reviews.llvm.org/D130427