[PATCH] D130676: [AArch64] Treat x18 as callee-saved in functions with Windows calling convention on Darwin

[Vladislav Dzhidzhoev via Phabricator via llvm-commits]

dzhidzhoev added a comment.

In D130676#3684388 <https://reviews.llvm.org/D130676#3684388>, @mstorsjo wrote:

> Where did you trigger this issue - by building Wine on macOS? (I did try building Wine on macOS/arm64 in 2020, and the logic for backing up x18 landed in 2019, so I wonder why I didn’t notice this issue… Maybe the Xcode clang didn’t contain that change yet at that point, or maybe it’s not noticed or the compiler is built without assertions?)

I was trying to investigate this issue https://github.com/llvm/llvm-project/issues/54079 and have found that the source code that doesn't compile with GlobalISel don't compile with SelectionDAG too, with debug clang build.

In D130676#3684388 <https://reviews.llvm.org/D130676#3684388>, @mstorsjo wrote:

> FWIW, with a recent refactoring in Wine, where a proper syscall interface is used between windows code and the native unix code, I think the whole mechanism for backing up/restoring x18 might be unnecessary, so we could consider ripping it out altogether too. I guess I could run some tests to see what the current state is…

TBH I'm not familiar with running Windows code on Darwin, so I would appreciate your feedback.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130676/new/

https://reviews.llvm.org/D130676