[PATCH] D130680: [IntegerDivision][AMDGPU] Use CreateLogicalOr to block poison propagation.

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/IntegerDivision.cpp:238
   // ;   %ret0_1      = icmp eq i32 %divisor, 0
   // ;   %ret0_2      = icmp eq i32 %dividend, 0
+  // ;   %ret0_3      = select i1 %ret0_1, i1 1, i1 %ret0_2
----------------
I think you actually need to freeze the inputs here. Otherwise an undef value could be picked to be non-zero here and zero in the ctlz call.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130680/new/

https://reviews.llvm.org/D130680