[PATCH] D130482: [LAA] Avoid non-determinism due to blocks order. PR56672

Wed Jul 27 23:21:03 PDT 2022

mkazantsev added inline comments.

================
Comment at: llvm/test/Analysis/LoopAccessAnalysis/pr56672.ll:32
+  store i32 %tmp9, i32* %tmp7, align 4
+  br i1 false, label %bb10, label %bb1
+
----------------
mkazantsev wrote:
> mkazantsev wrote:
> > fhahn wrote:
> > > nit: could this just be an unconditional branch? If not, `bb10` could be removed.
> > Yup, we can.
> Rrrr, scratch that. Thank you for finding this. No, removal of this branch still reproduces the bug, but the fix doesn't help for it.
Let's frame this patch as "algo depends on blocks order" issue. I will file this separately, along with modified test. The answer for now is "we can't remove this to show *this* bug".

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130482/new/

https://reviews.llvm.org/D130482