[PATCH] D129994: [RISCV] Add cost modelling for vector widenning integer reduction.

[Jianjian Guan via Phabricator via llvm-commits]

jacquesguan added a comment.

In D129994#3683293 <https://reviews.llvm.org/D129994#3683293>, @reames wrote:

> Tests?
>
> Also, how are reduction opcodes other than mul and add handled?

Sorry, I don't get your point, `getExtendedAddReductionCost` is only used for gettring the cost of `vecreduce.add(ext)` or `vecreduce.add(mul(ext, ext))` if `IsMLA` is true. So here we only need to handle `ADD`.

And for the test, I do not know well about CostModel test, `vecreduce.add(ext)` needs at least 2 instruction to make, but the test case would show the cost of each instruction, so any advice for making the case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129994/new/

https://reviews.llvm.org/D129994