[PATCH] D130315: [DWARF][BOLT] Implement new mechanism for DWARFRewriter

Rui Zhong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 27 17:05:12 PDT 2022


zr33 updated this revision to Diff 448213.
zr33 added a comment.

1. Rewrite finding TypeDIE part. It used find by traverse the tree and find by Attribute name.

However, this is not accurate because a type unit can have multiple Attributes which can be TypeDIE, but there is only 1 can represent the Type Unit. 
Currently, the TypeDIE is record during IR construction.

2. Re-calibrate the cross-CU reference in case there are type units in .debug_types section.

3. clean up code and fix nits.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130315/new/

https://reviews.llvm.org/D130315

Files:
  bolt/include/bolt/Core/DebugData.h
  bolt/include/bolt/Rewrite/DIEBuilder.h
  bolt/include/bolt/Rewrite/DWARFRewriter.h
  bolt/lib/Core/CMakeLists.txt
  bolt/lib/Core/DebugData.cpp
  bolt/lib/Rewrite/CMakeLists.txt
  bolt/lib/Rewrite/DIEBuilder.cpp
  bolt/lib/Rewrite/DWARFRewriter.cpp
  bolt/lib/Rewrite/RewriteInstance.cpp
  bolt/test/X86/asm-func-debug.test
  bolt/test/X86/dwarf3-lowpc-highpc-convert.s
  bolt/test/X86/dwarf4-ftypes-dwp-input-dwo-output.test
  bolt/test/X86/dwarf4-ftypes-dwp-input-dwp-output.test
  bolt/test/X86/dwarf5-dwarf4-monolithic.test
  bolt/test/X86/dwarf5-loclist-offset-form.test
  bolt/test/X86/dwarf5-split-dwarf4-monolithic.test
  bolt/test/X86/shared-abbrev.s
  llvm/include/llvm/CodeGen/DIE.h
  llvm/include/llvm/DebugInfo/DWARF/DWARFFormValue.h
  llvm/lib/DebugInfo/DWARF/DWARFFormValue.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130315.448213.patch
Type: text/x-patch
Size: 143554 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220728/d221c61e/attachment-0001.bin>


More information about the llvm-commits mailing list