[PATCH] D130592: [IR] Move support for dxil::TypedPointerType to LLVM core IR.

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

sorry, I haven't really been following https://discourse.llvm.org/t/rfc-better-support-for-typed-pointers-in-an-opaque-pointer-world, I'm reading through it

this change seems fine

but looking at `PointerTypeAnalysis::run`, if I'm understanding correctly, the pointee type can change based on optimizations. e.g. with a `load i32, ptr %p` the pointee type is `i32`, but if that load is eliminated and there are no users of the pointer, its pointee type is `i8`. and I believe this currently makes it into the generated DXIL. is this an issue? I'd assume so since the idea to use `i8*` everywhere doesn't seem to be the direction we're going


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130592/new/

https://reviews.llvm.org/D130592