[PATCH] D130605: [InstCombine] Add baseline tests for redundant sign bits count folds

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 27 14:42:44 PDT 2022


alexander-shaposhnikov marked an inline comment as done.
alexander-shaposhnikov added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/icmp.ll:4169
+; CHECK-NEXT:    [[Y:%.*]] = ashr i32 [[X:%.*]], 31
+; CHECK-NEXT:    [[Z:%.*]] = xor i32 [[Y]], [[X]]
+; CHECK-NEXT:    [[C:%.*]] = icmp ult i32 [[Z]], 1073741824
----------------
nikic wrote:
> Grep for "thward complexity-based canonicalization" for how to avoid this.
Phabricator has attached the comment to the wrong line (for the updated patch), nevertheless - many thanks,
I've fixed @redundant_sign_bit_count_ult_31_30_commute


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130605/new/

https://reviews.llvm.org/D130605



More information about the llvm-commits mailing list