[PATCH] D130587: [StandardInstrumentations] Assign names to basic blocks without names

[Jamie Schmeiser via Phabricator via llvm-commits]

jamieschmeiser accepted this revision.
jamieschmeiser added a comment.
This revision is now accepted and ready to land.

LGTM.

I'm wondering what would happen (after this change) if a function were to re-order the blocks (without any other change).  EG, the first 2 blocks in the function are swapped in the function list of blocks with no other change.  I suspect that this would then indicate that the change was the original block 1 was replaced with the new block 2 and the original block 2 was replaced with the new block 1 with the corresponding changes to the branches.  I think that may be unavoidable since the comparisons are string based.  Besides, it is better than crashing...

Thanks for fixing this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130587/new/

https://reviews.llvm.org/D130587