[PATCH] D130458: [llvm-objcopy] Support --{,de}compress-debug-sections for zstd

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

Yeah, I'm all in favor of smaller incremental patches - but more a question of the general API direction here. Whether to go with multiple entry points that each take the compression scheme and switch over it, or something with inheritance that switches over compression scheme once and then uses dynamic dispatch for compression/decompression/etc. I do see the point of ( https://reviews.llvm.org/D130516#3677580 ) that the inheritance scheme might be overkill for two (maybe three if the default/null/no-op compression scheme is worth having) implementations, but might still be suitable - I think it'll be easier to compare once patches are split up/more isolated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130458/new/

https://reviews.llvm.org/D130458