[PATCH] D129909: [GlobalISel][DebugInfo] salvageDebugInfo analogue for gMIR

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

In D129909#3681263 <https://reviews.llvm.org/D129909#3681263>, @dzhidzhoev wrote:

> In D129909#3680392 <https://reviews.llvm.org/D129909#3680392>, @aprantl wrote:
>
>> Nice! Is the primary implementation of salvageDebugInfoForDbgValue specific to GlobalISel, or should this be a general MIR utility that is accessible from all MIR passes?
>
> salvageDebugInfoForDbgValue is not specific to GlobalISel in fact. It could be accessible for other passes, with support of other unary/binary instructions.

In that case would recommend to move it into, e.g., `lib/CodeGen/MachineInstr.cpp` so it is clearly marked as a generic utility that encourages integration in other passes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129909/new/

https://reviews.llvm.org/D129909