[PATCH] D130482: [LAA] Avoid non-determinism due to blocks order. PR56672
Philip Reames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 27 13:00:32 PDT 2022
reames added a comment.
In D130482#3682855 <https://reviews.llvm.org/D130482#3682855>, @efriedma wrote:
> In general, I prefer not to refer to any issue that involves different inputs leading to different outputs as "non-determinism". It might be bad for various reasons to make the output sensitive to minor details of the input, but actual non-determinism is a much more serious problem because the output isn't reproducible.
Agreed here. Better wording would be to say that we're removing a block order sensitivity.
================
Comment at: llvm/lib/Analysis/LoopAccessAnalysis.cpp:2131
- // For each block.
- for (BasicBlock *BB : TheLoop->blocks()) {
+ // Traverse blocks in deterministic order, regardless of their storage in
+ // the loop info.
----------------
nit: replace deterministic with "fixed".
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130482/new/
https://reviews.llvm.org/D130482
More information about the llvm-commits
mailing list