[PATCH] D130645: Move mlir LogicalResult to llvm Support library
River Riddle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 27 12:29:22 PDT 2022
rriddle added inline comments.
================
Comment at: llvm/include/llvm/Support/LogicalResult.h:76
/// also providing a value on the success path.
-template <typename T>
-class LLVM_NODISCARD FailureOr : public Optional<T> {
+template <typename T> class LLVM_NODISCARD FailureOr : public Optional<T> {
public:
----------------
ezhulenev wrote:
> rriddle wrote:
> > The formatting here looks off.
> That's how the arcanist reformats the code once I upload it
Weird, oh well. Do whatever the formatter tells you.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130645/new/
https://reviews.llvm.org/D130645
More information about the llvm-commits
mailing list